Unify perform{Sync,Concurrent}WorkOnRoot implementation #31029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
acdlite
force-pushed
the
unify-performwork
branch
from
f84f79b to
2922b14
Compare
Over time the behavior of these two paths has converged to be essentially the same. So this merges them back into one function. This should save some code size and also make it harder for the behavior to accidentally diverge. (For the same reason, rolling out this change might expose some areas where we had already accidentally diverged.)
acdlite
force-pushed
the
unify-performwork
branch
from
2922b14 to
5833022
Compare
sebmarkbage
approved these changes
Sep 25, 2024
sebmarkbage
reviewed
Sep 25, 2024
|
|
||
| let renderEndTime = 0; | ||
| if (enableProfilerTimer && enableComponentPerformanceTrack) { | ||
| renderEndTime = now(); |
There was a problem hiding this comment.
I was originally confused by the diffing but this seems like it's now covered by performWorkOnRoot.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
Over time the behavior of these two paths has converged to be essentially the same. So this merges them back into one function. This should save some code size and also make it harder for the behavior to accidentally diverge. (For the same reason, rolling out this change might expose some areas where we had already accidentally diverged.) DiffTrain build for [3c7667a](3c7667a)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
Over time the behavior of these two paths has converged to be essentially the same. So this merges them back into one function. This should save some code size and also make it harder for the behavior to accidentally diverge. (For the same reason, rolling out this change might expose some areas where we had already accidentally diverged.) DiffTrain build for commit 3c7667a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over time the behavior of these two paths has converged to be essentially the same. So this merges them back into one function. This should save some code size and also make it harder for the behavior to accidentally diverge. (For the same reason, rolling out this change might expose some areas where we had already accidentally diverged.)